[PATCH] Initialize value of written in cli_splice_fallback

David Mulder dmulder at suse.com
Mon Jul 2 15:55:20 UTC 2018


Your insertion comes right after the while (remaining) block. We don't
leave that block until remaining evaluates false (until it reaches 0).
Your insertion sets written to initial_size - remaining (remaining ==
0). Wouldn't you simply set written to initial_size, since we don't
leave the block until everything is written?
Also, you used 2 spaces to indent your line. Please read README.Coding
(you should use tabs in c files for indentation).

On 06/26/2018 03:00 PM, Bailey Berro via samba-technical wrote:
> This patch fixes an issue where cli_splice_fallback did not set the number
> of bytes that are written, leading to splice returning uninitialized
> memory.
>
> I just sent in my Samba Developer's Certificate of origin.
>
> Thanks!
> Bailey
>
> Bailey Berro |  Software Engineer |  baileyberro at google.com |  310-433-2216

-- 
David Mulder
SUSE Labs Software Engineer - Samba
dmulder at suse.com
SUSE Linux GmbH, GF: Felix Imend├Ârffer, Jane Smithard, Graham Norton, HRB 21284 (AG N├╝rnberg)




More information about the samba-technical mailing list