[PATCH] Make behavior of "all" in the 'log level' consistent

[Andrew Bartlett]

On Mon, 2018-07-02 at 06:03 +0200, Timur I. Bakeyev via samba-technical 
wrote:
> For a while I wasn't able to understand, why when I set debug level for
> certain process with the command like:
> 
> # smbcontrol 1234 debug all:10
> 
> I get quite limited set of logs, missing VFS messages, for example. Then I
> realized that given command sets debug level ONLY to the "all" class,
> skipping all the rest classes:
> 
> PID 1234: all:10 tdb:2 printdrivers:2 lanman:2 smb:2 rpc_parse:2 rpc_srv:2
> rpc_cli:2 passdb:2 sam:2 auth:2 winbind:2 vfs:2 idmap:2 quota:2 acls:2
> locking:2 msdfs:2 dmapi:2 registry:2 scavenger:2 dns:2 ldb:2 tevent:2
> auth_audit:2 auth_json_audit:2 kerberos:2 drs_repl:2
> 
> and I should run:
> 
> # smbcontrol 1234 debug 10
> 
> Instead to get desired behavior.
> 
> I believe that this is an inconsistency in the behavior and "all:10" should
> have the same effect as "10" in this case.
> 
> So, here is the patch that fixes the problem.

G'Day Timur,

This looks good, but can we have test of some kind, perhaps a cmocka
test?

Also, can you clean up the use of DBGC_ALL and "all" elsewhere in the
codebase?

The issue I have is that now "all" is being used as a keyword for
(shock horror) changing the level of all the classes, the previous use
as 'default' or 'other' needs to be separated out, so it remains
possible to set a debug level for that.

Thanks,

Andrew Bartlett
-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba