[PATCH] ctdb-daemon: Only consider client ID for local database attach (bug 13500)

Amitay Isaacs amitay at gmail.com
Mon Jul 2 01:46:05 UTC 2018

On Mon, Jul 2, 2018 at 11:31 AM, Martin Schwenke via samba-technical
<samba-technical at lists.samba.org> wrote:
> The comment immediately above this code says "don't allow local
> clients to attach" and then looks up the client ID regardless of
> whether the request is local or remote.
> This means that an intentional remote attach from a client will not
> work correctly.  No real client should ever do that since clients
> attach so they an access databases locally.  Perhaps some sanity
> checks should be added.
> An alternate approach would be to zero the client_id in
> daemon_request_control_from_client() when forwarding controls from
> clients to other nodes.  A quick check of uses of client_id in
> controls suggests that this would not yield any surprises.  However,
> the broadcast logic is buried deeper than this level, so it isn't
> possible to handle this for broadcasts.  The semi-obvious fix for this
> is to unroll all existing broadcasts and remove the broadcast logic.
> Please review and maybe push...

Please drop the 3rd para in the commit message.

RB+ with the commit message change.


More information about the samba-technical mailing list