[Patches] for dbcheck (Re: [Patches] AD Database corruption after upgrade from <= 4.6 to 4.7 (bug #13228))

[Andrew Bartlett]

On Wed, 2018-01-31 at 00:43 +0100, Stefan Metzmacher wrote:
> > Also, should we restrict the test to run when the DB doesn't have
> > sortedLinks set (ie upgraded) so we avoid the expensive search and
> > possible re-introduction of links that are both deactivated and
> > expunged?
> 
> As the duplicates could also happen as consequence of
> https://bugzilla.samba.org/show_bug.cgi?id=13095
> I think we need to keep them.
> Maybe we can skip find_missing_forward_links_from_backlink,
> but it can be a patch on top I guess.

This is the part that was concerning me.  I would be more comfortable
in this mode, as we have seen extra backlinks (or missing forward
links, it was never entirely clear) in production of 4.6 installs and
am nervous about how widely --yes is used.

I also suspect (based on reports from customers on 4.6) that this might
not be the end of the story, but don't have anything concrete yet.  

Thanks,

Andrew Bartlett

-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba