[PATCH] Port of dsdb, dsdb_dns and samdb Python modules

Andrew Bartlett abartlet at samba.org
Tue Jan 30 23:31:34 UTC 2018

On Tue, 2018-01-30 at 19:35 +0100, Lumir Balhar via samba-technical
>          # Create a test user
> -        user_name = "samdb-testuser"
> +        user_name = "dsdb-user-" + str(uuid.uuid4())
>          user_pass = samba.generate_random_password(32, 32)
>          user_description = "Test user for dsdb test"

Please don't do this (at least not with a UUID).  The issue with this
pattern is that Samba doesn't currently enforce length constraints but
if used against windows that breaks.  (Yes, we should enforce the
length constraints). 

Instead, ensure the test cleans up in all cases (there is a way to
cleanup even in abort with addCleanup.

Otherwise it looks OK, I'll do a formal review once that is fixed up. 


Andrew Bartlett

Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba

More information about the samba-technical mailing list