[ctdb-common] Small improvements to sock_io's memory handling

Martin Schwenke martin at meltin.net
Tue Jan 30 03:57:23 UTC 2018


On Tue, 30 Jan 2018 11:20:59 +1100, Amitay Isaacs via samba-technical
<samba-technical at lists.samba.org> wrote:

> On Mon, Jan 29, 2018 at 6:46 PM, Swen Schillig <swen at vnet.ibm.com> wrote:
> > On Mon, 2018-01-29 at 15:11 +1100, Amitay Isaacs wrote:  
> >> Hi Swen,
> >>
> >> On Thu, Jan 25, 2018 at 9:13 PM, Swen Schillig via samba-technical
> >> <samba-technical at lists.samba.org> wrote:  
>  [...]  
> >>
> >> Can you move the #defines in the last patch next to the definition of
> >> sock_queue structure?  Also, the comment in sock_queue_setup.
> >> That should make code much more readable.  
> > Ok
> >
> > Here we go.
> >  
> 
> Reviewed-by: Amitay Isaacs <amitay at gmail.com>
> 
> Can I get another team member review?

Reviewed-by: Martin Schwenke <martin at meltin.net>

Will push after I check a detail with Swen...

peace & happiness,
martin



More information about the samba-technical mailing list