[PATCH] Remove unused finddcs_nbt.c

Andrew Bartlett abartlet at samba.org
Mon Jan 29 19:55:21 UTC 2018


On Mon, 2018-01-29 at 16:06 +0100, Volker Lendecke via samba-technical
wrote:
> Hi!
> 
> Review appreciated!
> 
> Thanks, Volker

Reviewed-by: Andrew Bartlett <abartlet at samba.org>

Pushed to autobuild.

As noted, this finishes work from 2012.  At the time, it got back in
via this:

commit 7f498f8987434b942718c139ec660fc2924238b0
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Fri Jun 8 20:43:18 2012 +1000

    Revert "s4-libcli: Remove unused finddcs_nbt"
    
    This reverts commit 06c90cb6f55701effa4cbafaf189a4de8471949b.
    
    There is genuine interest in using this currently unused code, so put
    it back into the tree to avoid folks having to rewrite it.
    
    It should be carefully hooked back into libnet at some point, and
    possibly told how to talk to the s3 nmbd socket if nbt_server isn't
    running.
    
    The wscript patches are skipped, due to the way the extra
    dep interacted with the build system.  When used, this will be resolved.
    
    Andrew Bartlett

However I can't recall what the 'genuine interest' was, and it hasn't
turned up in the five years since. 

Andrew Bartlett
-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba




More information about the samba-technical mailing list