[PATCH] Samba-VirusFilter: fix crash in virusfilter_vfs_close that was missed by me in review/cleanup
jra at samba.org
Wed Jan 24 20:41:58 UTC 2018
On Wed, Jan 24, 2018 at 11:35:16AM -0700, Trever L. Adams via samba-technical wrote:
> In the cleanup process a variable was set to be NULL which shouldn't
> have been done. For some reason I missed this in review/cleanup.
> This patch fixes that problem.
LGTM. RB+. Sorry for missing that in the review.
Ralph, can I get a second Team review ?
> From 50b2abdb9f59dab7cb8ebc39af37fd25fddb088c Mon Sep 17 00:00:00 2001
> From: "Trever L. Adams" <trever.adams at gmail.com>
> Date: Wed, 24 Jan 2018 10:42:11 -0700
> Subject: [PATCH 1/2] Fix virusfilter_vfs_close() crash missed in review and
> Signed-off-by: Trever L. Adams <trever.adams at gmail.com>
> source3/modules/vfs_virusfilter.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> diff --git a/source3/modules/vfs_virusfilter.c b/source3/modules/vfs_virusfilter.c
> index 9b29923110d..571073fbfff 100644
> --- a/source3/modules/vfs_virusfilter.c
> +++ b/source3/modules/vfs_virusfilter.c
> @@ -1303,7 +1303,7 @@ static int virusfilter_vfs_close(
> const char *cwd_fname = handle->conn->connectpath;
> struct virusfilter_config *config = NULL;
> - char *fname = fsp->fsp_name->base_name = NULL;
> + char *fname = fsp->fsp_name->base_name;
> int close_result = -1;
> int close_errno = 0;
> virusfilter_result scan_result;
More information about the samba-technical