[PATCH] Samba VirusFilter (version 12)

Trever L. Adams trever at middleearth.sapphiresunday.org
Tue Jan 23 22:11:28 UTC 2018

On 01/23/2018 12:01 PM, Ralph Böhme wrote:
> On Tue, Jan 23, 2018 at 09:10:46AM -0800, Jeremy Allison wrote:
>> LGTM. Ralph, can I get a second Team reviewer ?
> I'm really sorry, but virusfilter_do_infected_file_action() was in bad need of
> some refactoring.
> The attached patchset has a fixup commit where I essentially split
> virusfilter_do_infected_file_action() into smaller functions and made use of
> talloc_stackframe()s where appropriate for sane cleanup of temporary
> objects. Where needed out-arguments are talloc_moved from the temporary memory
> context to the memory context the caller provides.
> Trever, please check, fixup, test and resubmit. Sorry. The good news is, this
> seems to be the last issue that needs addressing. :)
> -slow
Hello Ralph,

Things look really good. I have made a few changes that are stylistic
(coding standard in one, the other, I prefer default actions be part of
the variable declaration, so I set action at the top of the functions.
There was one other small change, I believe. I already squashed it so...

All three actions have been well tested. (Except failure paths. I wasn't
sure how to force a failure of rename/delete.)

Hopefully this is ready now. Thank you all!!


-------------- next part --------------
A non-text attachment was scrubbed...
Name: av-version-15.patch
Type: text/x-patch
Size: 139764 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20180123/832598ab/av-version-15-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 886 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20180123/832598ab/signature-0001.sig>

More information about the samba-technical mailing list