Re: [PR PATCH] [Updated] Added smbc_SetConfiguration which lets the user set the smb.conf for â?¦

[Puran Chand]

Hi Jeremy,

I checked in the latest patch with your changes to github repo, the tests
are going fine.

https://travis-ci.org/samba-team/samba/builds/330197434?utm_source=github_status&utm_medium=notification

- Puran

On Thu, Jan 18, 2018 at 9:42 AM, Puran Chand <puran157 at gmail.com> wrote:

> Thanks Jeremy for the changes,
>
> Its picking up smb_new.conf for my test when I execute 'make test
> TESTS=libsmbclient".
>
> I even logged the path in torture test and I can see it in st/subunit file
> as proper path and the test continues fine.
>
> Please let me know if I am missing anything and I would be happy to look
> into it.
>
> - Puran
>
> On Thu, Jan 18, 2018 at 6:19 AM, Jeremy Allison <jra at samba.org> wrote:
>
>> On Thu, Jan 18, 2018 at 10:12:57AM +1300, Andrew Bartlett wrote:
>> > On Wed, 2018-01-17 at 13:03 -0800, Jeremy Allison wrote:
>> > > On Thu, Jan 18, 2018 at 08:01:06AM +1300, Andrew Bartlett via
>> samba-technical wrote:
>> > > > On Wed, 2018-01-17 at 15:22 +0100, Volker Lendecke wrote:
>> > > > > On Wed, Jan 17, 2018 at 02:00:00PM +0000, Github bot account via
>> samba-technical wrote:
>> > > > > > There is an updated pull request by puran157 against master on
>> the Samba Samba Github repository
>> > > > > >
>> > > > > > https://github.com/puran157/samba
>> set_configuration_libsmbclient
>> > > > > > https://github.com/samba-team/samba/pull/119
>> > > > > >
>> > > > > > Added smbc_SetConfiguration which lets the user set the
>> smb.conf for …
>> > > > > > …libsmbclient code
>> > > > > >
>> > > > > > Signed-off-by: Puran Chand <pchand at vmware.com>
>> > > > > >
>> > > > > > A patch file from https://github.com/samba-team/
>> samba/pull/119.patch is attached
>> > > > >
>> > > > > Better. RB+. Someone else?
>> > > >
>> > > > My concern is this line:
>> > > >
>> > > > + torture_assert_int_equal(tctx, smbc_setConfiguration(ctx,
>> > > > "../testdata/samba3/smb_new.conf"), 0, "setConfiguration conf file
>> not
>> > > > found");
>> > > >
>> > > > This feels a little too sensitive to working directories.
>> > > >
>> > > > I think we should have that passed in from the command line and
>> > > > accessed with torture_setting_string().
>> > > >
>> > > > As a use example see:
>> > > > source4/torture/krb5/kdc-canon-heimdal.c:
>>  test_data->krb5_hostname = torture_setting_string(tctx, "krb5-hostname",
>> "");
>> > > >
>> > > > That example is called by adding this to the commandline in
>> > > > source4/selftest/tests.py:
>> > > >
>> > > > '--option=torture:krb5-hostname=testallowed'
>> > > >
>> > > > Otherwise, a big thanks to Volker for looking over the style issues
>> > > > here.  I'm sorry I didn't get this feedback earlier.
>> > >
>> > > OK, here is an updated version incorporating these changes
>> > > with my review. Passes local make test.
>> > >
>> > > Can I get you or Volker to re-review and I'll push.
>> >
>> > Reviewed-by: Andrew Bartlett <abartlet at samba.org>
>> >
>> > Looks great.  Thank you so much for sorting this out.
>> >
>> > Perhaps file a bug so we can backport it into 4.8, Puran's other change
>> > landed a few weeks back but this didn't get our review attention in
>> > time.
>>
>> Well that's very strange. Despite passing local make test
>> it fails on sn-devel with:
>>
>> UNEXPECTED(failure): samba3.libsmbclient.setConfiguration(nt4_dc)
>> REASON: Exception: Exception: ../source4/torture/libsmbclient/libsmbclient.c:132:
>> smbc_setConfiguration(ctx, new_smb_conf) was -1 (0xFFFFFFFF), expected 0
>> (0x0): setConfiguration conf file not found
>>
>> Let me try and figure out what is different in the local
>> environment from sn-devel.
>>
>> Jeremy.
>>
>
>