[PR PATCH] [Updated] Added smbc_SetConfiguration which lets the user set the smb.conf for â?¦

[Andrew Bartlett]

On Wed, 2018-01-17 at 15:22 +0100, Volker Lendecke wrote:
> On Wed, Jan 17, 2018 at 02:00:00PM +0000, Github bot account via samba-technical wrote:
> > There is an updated pull request by puran157 against master on the Samba Samba Github repository
> > 
> > https://github.com/puran157/samba set_configuration_libsmbclient
> > https://github.com/samba-team/samba/pull/119
> > 
> > Added smbc_SetConfiguration which lets the user set the smb.conf for …
> > …libsmbclient code
> > 
> > Signed-off-by: Puran Chand <pchand at vmware.com>
> > 
> > A patch file from https://github.com/samba-team/samba/pull/119.patch is attached
> 
> Better. RB+. Someone else?

My concern is this line:

+	torture_assert_int_equal(tctx, smbc_setConfiguration(ctx,
"../testdata/samba3/smb_new.conf"), 0, "setConfiguration conf file not
found");

This feels a little too sensitive to working directories. 

I think we should have that passed in from the command line and
accessed with torture_setting_string().

As a use example see:
source4/torture/krb5/kdc-canon-heimdal.c:       test_data->krb5_hostname = torture_setting_string(tctx, "krb5-hostname", "");

That example is called by adding this to the commandline in
source4/selftest/tests.py:

'--option=torture:krb5-hostname=testallowed'

Otherwise, a big thanks to Volker for looking over the style issues
here.  I'm sorry I didn't get this feedback earlier.

(Note that this uses loadparm under the hood, in case it acts weird,
but it should be fie). 

Andrew Bartlett
-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba