PATCH: python3 smb module

David Mulder dmulder at
Wed Jan 17 14:56:46 UTC 2018

You have some whitespace problems in source4/libcli/wscript_build
In python you should use 4 spaces for indentation and no tabs (you have
a couple tabs littered in their). You also have some trailing line

Otherwise looks good.

On 01/17/2018 03:32 AM, Noel Power via samba-technical wrote:
> Before Christmas playing with something where I needed to play with
> samba + python3 I found the smb module was not ported, I scratched
> together a patch (and forgot about it 'till the recent python3 porting
> messages :-)) Please have a look, comments and corrections welcome
> Noel

David Mulder
SUSE Labs Software Engineer - Samba
dmulder at
SUSE Linux GmbH, GF: Felix Imend├Ârffer, Jane Smithard, Graham Norton, HRB 21284 (AG N├╝rnberg)

More information about the samba-technical mailing list