[PATCH] whoami test fixes

[Andreas Schneider]

On Tuesday, 16 January 2018 04:12:22 CET Andrew Bartlett wrote:
> On Sun, 2018-01-14 at 08:17 +1300, Andrew Bartlett via samba-technical
> 
> wrote:
> > On Fri, 2018-01-12 at 09:34 +0100, Andreas Schneider via samba-
> > 
> > technical wrote:
> > > I've had a short look with Ralph yesterday. Currently a patch for the
> > > change secret test is on the way to autobuild. The whoami test fails
> > > creating an smb connection to nt4_member using the machine account. It
> > > is possible that an earlier test breaks the secret.
> > > 
> > > Possible culprit, see attached (in autobuild right now).
> > 
> > With the asn-whomai branch here:
> > 
> > https://git.samba.org/?p=abartlet/samba.git/.git;a=shortlog;h=refs/heads/a
> > sn-whoami
> > 
> > (this patch, and the other flapping markers on then-master) I get 2
> > failures setting up ad_member and 6 successful runs.  I therefore think
> > this patch is correct and removes this flapping test (but I'm not clear
> > exactly how...).
> > 
> > As before, the full logs are in the seafile link:
> > 
> > https://seafile.catalyst.net.nz/d/92adffd354044ffaa3c4/
> 
> Andreas,
> 
> Could you help explain to me how your fix works?  It certainly seems
> to, so the attached revert of the flapping file is appropriate.

I did not fix anything. I looked what tests are running before the whoami test 
and expected those. The test failed connecting with the machine account and 
the test before did a "wbinfo --change-secret". However it failed to verify 
that the change secret was successful. So I've added a check to make sure we 
do not break.

If it is a fix, then the fix is calling 'net ads testjoin' after 'wbinfo --
change-secret'.


	Andreas


-- 
Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             asn at samba.org
www.samba.org