[PATCH] whoami test fixes

[Andrew Bartlett]

On Sun, 2018-01-14 at 08:17 +1300, Andrew Bartlett via samba-technical
wrote:
> On Fri, 2018-01-12 at 09:34 +0100, Andreas Schneider via samba-
> technical wrote:
> > 
> > I've had a short look with Ralph yesterday. Currently a patch for the change 
> > secret test is on the way to autobuild. The whoami test fails creating an smb 
> > connection to nt4_member using the machine account. It is possible that an 
> > earlier test breaks the secret.
> > 
> > Possible culprit, see attached (in autobuild right now).
> 
> With the asn-whomai branch here:
> 
> https://git.samba.org/?p=abartlet/samba.git/.git;a=shortlog;h=refs/heads/asn-whoami
> 
> (this patch, and the other flapping markers on then-master) I get 2
> failures setting up ad_member and 6 successful runs.  I therefore think
> this patch is correct and removes this flapping test (but I'm not clear
> exactly how...).  
> 
> As before, the full logs are in the seafile link:
> 
> https://seafile.catalyst.net.nz/d/92adffd354044ffaa3c4/

Andreas,

Could you help explain to me how your fix works?  It certainly seems
to, so the attached revert of the flapping file is appropriate. 

Please clarify, then review and push.

Thanks!

Andrew Bartlett

-- 
Andrew Bartlett
https://samba.org/~abartlet/
Authentication Developer, Samba Team         https://samba.org
Samba Development and Support, Catalyst IT   
https://catalyst.net.nz/services/samba



-------------- next part --------------
From 7f6f737ed71ddd4b46d8d96825b4dff888576114 Mon Sep 17 00:00:00 2001
From: Andrew Bartlett <abartlet at samba.org>
Date: Tue, 16 Jan 2018 16:09:51 +1300
Subject: [PATCH] Revert "Mark whoami test flapping"

This reverts commit 6b09ab2139751637dc773f6ef7fb7f0dd99605e0.

This no longer flaps after 8d90f2a03e58f34f36d345d31c5ca6090d37ff54

Signed-off-by: Andrew Bartlett <abartlet at samba.org>
---
 selftest/flapping.d/whoami | 1 -
 1 file changed, 1 deletion(-)
 delete mode 100644 selftest/flapping.d/whoami

diff --git a/selftest/flapping.d/whoami b/selftest/flapping.d/whoami
deleted file mode 100644
index 82f6356cd41..00000000000
--- a/selftest/flapping.d/whoami
+++ /dev/null
@@ -1 +0,0 @@
-^samba3.unix.whoami machine account.whoami\(nt4_member:local\)
-- 
2.11.0