[PATCH v3] fixes account locked when using winbind refresh tickets

David Disseldorp ddiss at suse.de
Mon Jan 15 15:48:02 UTC 2018


Hi Andreas,

On Mon, 15 Jan 2018 16:29:33 +0100, Andreas Schneider via samba-technical wrote:

> +static uint64_t fetch_last_password_change(struct WINBINDD_CCACHE_ENTRY 
> *entry)
> +{
> +	TALLOC_CTX *ctx = talloc_new(entry);
> 
> Please use:
> 
> 	TALLOC_CTX *frame = talloc_stackframe();
> 
> This is cheaper than talloc_new().

Are there any public real-world benchmark results that show this? In
terms of readability I find the former much easier to follow.

Cheers, David



More information about the samba-technical mailing list