Some fixes for password-server conf option and IPv6

Isaac Boukris iboukris at gmail.com
Mon Jan 15 14:13:54 UTC 2018


On Mon, Jan 15, 2018 at 3:57 PM, Volker Lendecke
<Volker.Lendecke at sernet.de> wrote:
> On Mon, Jan 15, 2018 at 03:51:14PM +0200, Isaac Boukris via samba-technical wrote:
>> On Sat, Jan 13, 2018 at 5:30 PM, Isaac Boukris <iboukris at gmail.com> wrote:
>> > Hello all,
>> >
>> > Find attached two patches.
>>
>> Hi, I fixed the comment in the second patch, reattaching both.
>>
>> btw, I wonder if the logic to prefer IPv4 address over IPv6 when an
>> FQDN resolves to both still make sense nowdays.
>> Otherwise, the code around could use a good cleanup, see:
>> https://buildfarm.opencsw.org/source/xref/samba/source3/libsmb/namequery.c#3293
>
> If both v4 and v6 work, why prefer v6?

We shouldn't prefer v6 either, just ignore the family, it's less code.



More information about the samba-technical mailing list