[PATCH] Do not leave random talloc magic in free()'ed memory, fix abort message

Jeremy Allison jra at samba.org
Fri Jan 12 23:02:11 UTC 2018


On Sat, Jan 13, 2018 at 12:00:19AM +0100, David Disseldorp via samba-technical wrote:
> On Fri, 12 Jan 2018 13:48:15 +1300, Andrew Bartlett via samba-technical wrote:
> 
> > +		talloc_log("talloc: access after free error - first free may be at %s\n", tc->name);
> 
> If the talloc_chunk is potentially invalid here, then I'd prefer to
> avoid logging any strings off it. Should we make this a "...%p\n", tc)
> instead, or am I being overly paranoid?

One can never be too paranoid with these things. Yep, I missed
that in the review. +1 for this change :-).



More information about the samba-technical mailing list