[PATCH] Do not leave random talloc magic in free()'ed memory

[Andrew Bartlett]

On Fri, 2018-01-12 at 08:21 +0100, Stefan Metzmacher wrote:
> Hi Andrew,
> 
> I saw these patches in your current autobuild.
> 
> I tried to pick them for 4.8.0 (including talloc-2.1.11),
> but it failed locally with:
> 
> [2(1)/2 at 0s] samba4.local.talloc
> talloc: access after free error - first free may be at
> ../lib/talloc/talloc.c:1978_talloc_realloc
> Bad talloc magic value - access after free
> UNEXPECTED(error): samba4.local.talloc.magic_free_protection(none)
> REASON: Exception: Exception: Test was never started
> UNEXPECTED(error): samba4.local.talloc.magic_protection(none)
> (samba.subunit.RemotedTestCase)
> REASON: was started but never finished!
> UNEXPECTED(error): samba4.local.talloc.talloc(none)
> (samba.subunit.RemotedTestCase)
> REASON: was started but never finished!
> 
> I don't think we need this for 4.8.0rc1.

Drat.  I tested those in the lib/talloc sub-build but not in the
included master build.  Probably just needs a success line, but I
agree, it is just a 'nice to have' and I have bugs filed in any case.

Andrew Bartlett
-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba