[PATCH] vfs_glusterfs: Add fallocate support for vfs_glusterfs

[Michael Adam]

On 2018-01-10 at 12:34 -0800, Jeremy Allison via samba-technical wrote:
> Hi Sachin,
> 
> Unfortunately this won't compile on an older
> version of Gluster - it doesn't seem to have
> glfs_discard() or glfs_fallocate().

Great point, thanks for catching this, Jeremy!

Waiting for a patch update to address this.
Otherwise the patch looks good to me.

Cheers - Michael

> What version of gluster were these added to ?
> 
> I think you might also need to update this
> code in source3/wscript that detects the
> version of the glusterfs-api.
> 
>     if Options.options.with_glusterfs:
>         conf.CHECK_CFG(package='glusterfs-api', args='"glusterfs-api >= 4" --cflags --libs',
>                        msg='Checking for glusterfs-api >= 4', uselib_store="GFAPI")
>         conf.CHECK_HEADERS('glusterfs/api/glfs.h', lib='gfapi')
>         conf.CHECK_LIB('gfapi', shlib=True)
> 
> Jeremy.
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 163 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20180111/386db31a/signature.sig>