[PATCH] vfs_ceph: add fs_capabilities hook to avoid local statvfs

David Disseldorp ddiss at suse.de
Wed Jan 10 15:01:12 UTC 2018

On Tue, 9 Jan 2018 17:05:22 -0800, Jeremy Allison wrote:

> On Wed, Jan 10, 2018 at 01:45:04AM +0100, David Disseldorp via samba-technical wrote:
> > Patch attached. Feedback/push appreciated.  
> Oh, yes - sys_statvfs() against a ceph filesystem path isn't
> good. RB+ and pushed.

Thanks Jeremy.

> As an additional patch, should we change vfswrap_fs_capabilities()
> to go through SMB_VFS_STATVFS() instead of calling locally, or
> is there a reason for calling the system function (I have a
> vague recollection around this) ?

Agreed, I think it makes sense to use the VFS hook here. Please see

As a side note, it'd be nice to have a stack based synthetic_smb_fname()
helper, and get rid of quite a few (IMO) ugly talloc_tos() callers.

Cheers, David
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-vfs_default-use-VFS-statvfs-macro-in-fs_capabilities.patch
Type: text/x-patch
Size: 1800 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20180110/75ca4e0a/0001-vfs_default-use-VFS-statvfs-macro-in-fs_capabilities.bin>

More information about the samba-technical mailing list