Re: [PR PATCH] [Updated] Added smbc_SetConfiguration which lets the user set the smb.conf for …

[Puran Chand]

Hi All,

This patch add an API in libsmbclient.h (smbc_setConfiguration())
which provides
flexibility to read and apply configuration from different smb.conf while
calling libsmbclient APIs.

This overrides the configuration parameters which are defined in new
configuration file and do not change the defaults. Kindly refer old PR to
see the discussion. (https://github.com/samba-team/samba/pull/113)

I have also added a test smb_new.conf in testdata/samba3 directory which is
loaded during torture test and all the configuration is verified after
smbc_setConfiguration() call. The configuration is restored to default
before  the torture test exits so that other torture test are not affected.

There were review comments on older PR(
https://github.com/samba-team/samba/pull/113) which are also addressed in
this PR.

I apologize for raising it as part of new PR since I accidentally deleted
the branch from my samba fork over github while rebasing.

Kindly review.

Puran

On Wed, Jan 10, 2018 at 2:28 PM, Github bot account via samba-technical <
samba-technical at lists.samba.org> wrote:

> There is an updated pull request by puran157 against master on the Samba
> Samba Github repository
>
> https://github.com/puran157/samba set_configuration_libsmbclient
> https://github.com/samba-team/samba/pull/119
>
> Added smbc_SetConfiguration which lets the user set the smb.conf for …
> …libsmbclient code
>
> Signed-off-by: Puran Chand <pchand at vmware.com>
>
> A patch file from https://github.com/samba-team/samba/pull/119.patch is
> attached
>