[PATCHES v1] GPO fixes

David Mulder dmulder at suse.com
Tue Jan 9 18:44:53 UTC 2018

On 01/09/2018 11:40 AM, Andrew Bartlett wrote:
> On Tue, 2018-01-09 at 07:24 -0700, David Mulder wrote:
>> On 01/09/2018 02:44 AM, Garming Sam wrote:
>>> Hi,
>>> I think I'm mostly fine with the first five patches (the docs need to
>>> be tweaked to remove the mention to env vars though, attached as a
>>> patch). Although most of the concerns we originally raised (in regards
>>> to the KDC settings) have now been addressed, I still think having a
>>> release with it off by default is sensible (and some curious users get
>>> to have a play with it).
>> Sounds ok with me. Let's plan on leaving it disabled then.
>>> I think the disabling mechanism needs some more thought, I don't think
>>> it's appropriate to put the .disabled files under the same
>>> sub-directory as the module (and particularly in the python
>>> directory). There might also be other issues like having it installed
>>> vs running from a source-tree.
>> Currently it's setup to follow the .py file wherever it might be
>> installed, so I don't think the installed vs running directory would be
>> an issue.
>>> Perhaps metze had some more thoughts on the most appropriate location
>>> and/or format. You'd normally expect such files to exist in an /etc/,
>>> neighbouring where our smb.conf lives.
>> Yes, I wasn't really sure about the proper location for these, but
>> having them in the same directory as the .py files was what metze
>> suggested. Maybe let's leave the disable patch out for now? It isn't
>> particularly useful at this point anyway, since there is only one gp_ext.
> Thanks.  I plan to review this into master with Garming today in time
> for 4.8, assuming no additional issues come up.  Thank you very much
> for your patience on this and I'm sorry this area isn't moving forward
> in the way you would hope.
No worries.
> Andrew Bartlett

David Mulder
SUSE Labs Software Engineer - Samba
dmulder at suse.com
SUSE Linux GmbH, GF: Felix Imend├Ârffer, Jane Smithard, Graham Norton, HRB 21284 (AG N├╝rnberg)

More information about the samba-technical mailing list