[PATCH] Fail to copy file with empty FinderInfo from Windows client to Samba share with vfs_fruit
jra at samba.org
Tue Jan 9 04:04:46 UTC 2018
On Mon, Jan 08, 2018 at 02:43:58PM -0800, Jeremy Allison via samba-technical wrote:
> On Mon, Jan 08, 2018 at 07:13:49PM +0100, Ralph Böhme wrote:
> > On Tue, Jan 02, 2018 at 02:33:56PM +0100, Ralph Böhme wrote:
> > > On Fri, Dec 08, 2017 at 12:12:10PM +0100, Ralph Böhme via samba-technical wrote:
> > > > Currently when a client sends a AFP_AfpInfo stream where the contained
> > > > FinderInfo blob is all 0, vfs_fruit will somewhat hackish delete the stream from
> > > > the backing store. This causes subsequent operations on the same filehandle to
> > > > fail for certain operations, also depending on the setting of fruit:metadata.
> > > >
> > > > The correct implementation of the stream removal would be setting
> > > > delete-on-close on the filehandle, while at the same time checking in
> > > > delete-on-close is set in the stream-listing function.
> > > >
> > > > Patch attached, please review & push if happy. Thanks!
> > >
> > > anyone? Thanks!
> > Another ping.
> RB+ and pushed after rebasing to work on current master :-).
Ralph, the autobuild keeps failing with:
[720(4483)/2230 at 1h11m38s] samba3.libsmbclient(ad_dc)
[721(4488)/2230 at 1h11m38s] idmap.rfc2307(ad_member_rfc2307)
UNEXPECTED(failure): idmap.rfc2307.Testing for expected group memberships(ad_member_rfc2307)
REASON: Exception: Exception:
which I don't think is related. I'll try again tomorrow.
More information about the samba-technical