[PATCH] Fail to copy file with empty FinderInfo from Windows client to Samba share with vfs_fruit

Ralph Böhme slow at samba.org
Mon Jan 8 18:13:49 UTC 2018


On Tue, Jan 02, 2018 at 02:33:56PM +0100, Ralph Böhme wrote:
> On Fri, Dec 08, 2017 at 12:12:10PM +0100, Ralph Böhme via samba-technical wrote:
> > Currently when a client sends a AFP_AfpInfo stream where the contained
> > FinderInfo blob is all 0, vfs_fruit will somewhat hackish delete the stream from
> > the backing store. This causes subsequent operations on the same filehandle to
> > fail for certain operations, also depending on the setting of fruit:metadata.
> > 
> > The correct implementation of the stream removal would be setting
> > delete-on-close on the filehandle, while at the same time checking in
> > delete-on-close is set in the stream-listing function.
> > 
> > Patch attached, please review & push if happy. Thanks!
> 
> anyone? Thanks!

Another ping.

Thanks!
-slow

-- 
Ralph Boehme, Samba Team       https://samba.org/
Samba Developer, SerNet GmbH   https://sernet.de/en/samba/



More information about the samba-technical mailing list