[PATCH] selftest: close connections after tests in samba4.ldap.acl.python
Andreas Schneider
asn at samba.org
Mon Jan 8 08:47:33 UTC 2018
On Monday, 8 January 2018 02:13:18 CET Jamie McClymont via samba-technical
wrote:
> (now with missing signoff!)
Thanks for those patches. But normally you have setup and teardown functions
which should be responsible for allocating and cleaning up memory, creating
and deleting users etc. Those setup functions can then be shared in different
tests.
A lot of python tests don't seem to follow basic unit testing rules. So I
think just correctly working with setup and teardown would fix a lot more bugs
we have in those tests.
Just my 2 cents.
Andreas
--
Andreas Schneider GPG-ID: CC014E3D
Samba Team asn at samba.org
www.samba.org
More information about the samba-technical
mailing list