[PATCH] Bunch of options for vfs_fileid

Jeremy Allison jra at samba.org
Fri Jan 5 23:04:24 UTC 2018

On Fri, Jan 05, 2018 at 10:44:27AM +0100, Ralph Böhme wrote:
> Hi!
> Attached is a patchset with a bunch of new options for vfs_fileid. They have
> been in use downstream by a vendor for quite some time and I would like to bring
> them upstream.
> The following options are added:
>   fileid:fstype deny = LIST
>   fileid:fstype allow = LIST
>   fileid:mntdir deny = LIST
>   fileid:mntdir allow = LIST
>   fileid:algorithm = hostname
>   fileid:algorithm = fsname_nodirs
>   fileid:nolockinode
>   fileid:algorithm = fsname_norootdir
> The patch that adds the fstype/mntdir options has been discussed previously
> about two years ago:
> https://lists.samba.org/archive/samba-technical/2016-January/111553.html
> Afaict consensus was that it's a useful addition and concerns raised by Jeremey
> where addressed by better explanation of the use case. The patch then never went
> upstream though.

Thanks for the link on the discussion - that helped refresh my memory.

> All parameters are explained in manpage updates.
> The use case of the new algorithms is to mitigate contention on locking.tdb
> records in a cluster.
> "fileid:algorithm = fsname_norootdir" is probably the most useful one as it
> mitigates contention on the locking.tdb record on the root directory of shares
> which was seen frequently with certain workloads.
> I'm wrapping all patches in one patchset, as the patches build on top of one
> another, eg the algorithm added for "fileid:algorithm = hostname" is used by the
> the other new algorithm.
> Please review&push if happy. Thanks!

LGTM, RB+ and pushed - thanks !


More information about the samba-technical mailing list