[PATCH] Add a somewhat hackish option to limit the size of TimeMachine backups
jra at samba.org
Fri Jan 5 22:40:00 UTC 2018
On Fri, Jan 05, 2018 at 11:57:42AM +0100, Ralph Böhme via samba-technical wrote:
> On Thu, Jan 04, 2018 at 05:08:29PM -0800, Jeremy Allison wrote:
> > On Wed, Jan 03, 2018 at 11:04:30AM +0100, Ralph Böhme wrote:
> > >
> > > The good thing: it has a test! :)
> > >
> > > Please review & push if happy. Thanks!
> > Looks pretty good.
> > There are just a couple of comments inline. Can you take a look
> > and get back to me ?
> > > + uint64_t uint64;
> > ^^^^^^
> > 'uint64' is a *horrible* confusing name
> > for a variable. It looks like a type definition.
> > Please change it to something meaningful.
> > > + *dfree = *dsize - (state.total_size / 512);
> > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> > Can this go negative ? What would
> > happen if it did ?
> You bet it can! Thanks for catching this. Fixed.
> I also noticed that the test failed in make test. I didn't notice this as I kept
> running it directly from smbtorture against a local server and share where it
> worked. While at it, I moved the test to it's own test-suite so I can run it
> against a dedicated new share that has the necessary options set up.
LGTM. Thanks for the fixes ! RB+ and pushed.
More information about the samba-technical