[PATCH] Fix bug #13193 - incorrect use of kernel oplock logic.

Jeremy Allison jra at samba.org
Wed Jan 3 20:10:54 UTC 2018


On Wed, Jan 03, 2018 at 07:41:07PM +0100, Volker Lendecke wrote:
> On Wed, Jan 03, 2018 at 09:56:27AM -0800, Jeremy Allison via samba-technical wrote:
> > Patch is fairly self-explainatory. Reporter
> > confirmed the fix. Causes all kernel oplock
> > handling functions to use identical logic to
> > detect kernel oplocks being on or off.
> > 
> > Please review and push if happy !
> 
> Just a minor nit-pick: I find "koplocks!=NULL" easier to read than
> just "koplocks". But that might be just me, sorry.

Updated version attached that makes all code use (koplocks!=NUL).

Let me know what you think. Cheers,

	Jeremy.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-s3-smbd-Use-identical-logic-to-test-for-kernel-oploc.patch
Type: text/x-diff
Size: 4205 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20180103/3c9d8eb0/0001-s3-smbd-Use-identical-logic-to-test-for-kernel-oploc.diff>


More information about the samba-technical mailing list