[PR PATCH] [Updated] Add #include <unistd.h> to provide prototype for getopt()

github at samba.org github at samba.org
Wed Jan 3 09:00:45 UTC 2018


There is an updated pull request by candlerb against master on the Samba Samba Github repository

https://github.com/candlerb/samba candlerb/crackcheck-unistd
https://github.com/samba-team/samba/pull/116

Add #include <unistd.h> to provide prototype for getopt()
Fixes warning when building crackcheck:

~~~
# make
gcc  -O2   -c -o crackcheck.o crackcheck.c
crackcheck.c: In function ‘main’:
crackcheck.c:91:15: warning: implicit declaration of function ‘getopt’ [-Wimplicit-function-declaratio
  while ( (c = getopt(argc, argv, "d:cs")) != EOF){
               ^
~~~


A patch file from https://github.com/samba-team/samba/pull/116.patch is attached
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: github-pr-candlerb/crackcheck-unistd-116.patch
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20180103/6edd16d2/crackcheck-unistd-116.patch>


More information about the samba-technical mailing list