[PATCH] Samba VirusFilter (version 11)

Trever L. Adams trever at middleearth.sapphiresunday.org
Mon Jan 1 19:45:17 UTC 2018

On 12/28/2017 08:41 AM, jim via samba-technical wrote:
> Trever
> Status of functions returning virusfilter_result should be checked
> against correct constants (not true or false).
> A few more nits.
> Jim
> Tests for type virusfilter_result should be against correct constants
> - not against true.
> Or, it should be assigned to a bool variable like virusfilter_io_readl.
> result != true should be result != VIRUSFILTER_RESULT_OK (many places) 


Thank you so much for your feed back. I am sorry for the delayed
response. I missed this email last week. Your feedback made me realize
that the consistency I once hoped for (using the virusfilter_result)
everywhere was not a good idea. I have tried to 'simplify' the return
types in addition to making the changes you suggested. If bool is
enough, I am now using bool. If it needs an int, use that, if it needs
the full virusfilter_result, use that.

As I keep missing things, I am attaching the incremental patch.
Hopefully, this will help find the last nits, coding style violations
and any bugs (which this process has helped me uncover and fix) remaining.

Thank you to all who have been so helpful.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-Do-more-to-correct-coding-style-and-nits-as-Jim-put-.patch
Type: text/x-patch
Size: 13440 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20180101/a7066fa7/0006-Do-more-to-correct-coding-style-and-nits-as-Jim-put-.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 886 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20180101/a7066fa7/signature.sig>

More information about the samba-technical mailing list