[PATCH] Add support for fall-through handling if the compiler supports it

Andrew Bartlett abartlet at samba.org
Wed Feb 28 20:54:32 UTC 2018


On Mon, 2018-02-26 at 11:23 +0100, Andreas Schneider wrote:
> On Friday, 23 February 2018 19:07:44 CET Andrew Bartlett wrote:
> > On Tue, 2018-02-20 at 17:32 +0100, Andreas Schneider via samba-
> > 
> > technical wrote:
> > > Yes, that's true. I've addressed it in the attached patchset.
> > 
> > I tried to push this, but it failed autobuild on ldb.
> > 
> > Can you push it to github and make a pull request?  That will trigger a
> > Travis CI job that should cover everything on 14.04.  (or do a private
> > autobuild).
> 
> I've fixed it, the configure check for the attribute needed to be build with 
> '-Werror' to detect it correctly.
> 
> The latest rebased patchset is attached.
> 
> A travis CI run is in the following pull request:
> https://github.com/samba-team/samba/pull/133
> 
> 
> Thanks for the review.

Can you please split out or explain the logic changes in:

auth:credentials: Add FALL_THROUGH statements in credentials.c
    
    Signed-off-by: Andreas Schneider <asn at samba.org>

The rest look OK so far, but the eyes tend to glaze over after a almost
60 patches :-)

Andrew Bartlett

-- 
Andrew Bartlett
https://samba.org/~abartlet/
Authentication Developer, Samba Team         https://samba.org
Samba Development and Support, Catalyst IT   
https://catalyst.net.nz/services/samba







More information about the samba-technical mailing list