[PR PATCH] [Updated] Bulk octal and exception fixup changes

github at samba.org github at samba.org
Wed Feb 28 15:39:03 UTC 2018

There is an updated pull request by noelpower against master on the Samba Samba Github repository

https://github.com/noelpower/samba bulk_octal_and_except

Bulk octal and exception fixup changes
This patch converts literal octal numbers to a format that is acceptable in both python2 and python3.

           os.chmod(some_path, 0770)      # valid in python2 only
           os.chmod(some_path, 0o770)    # valid in python2 and python3

additionally this pull request contains a patches to do a bulk conversion where except clause specifies a tuple following the exception name. This format is illegal in python3 e.g.


    except LdbError, (num, msg):
    except LdbError as e:
         (num, msg) = e.args

The patch set follows the same grouping as a previous 'Bulk' commit for converting except clause with ',' instead of 'as'

A patch file from https://github.com/samba-team/samba/pull/135.patch is attached
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: github-pr-bulk_octal_and_except-135.patch
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20180228/35d21866/github-pr-bulk_octal_and_except-135-0001.patch>

More information about the samba-technical mailing list