[PR PATCH] [Updated] samba-tool domain trust: fix trust compatibility to Windows Server 1709 and FreeIPA

Stefan Metzmacher metze at samba.org
Tue Feb 27 16:17:37 UTC 2018

Hi Alexander,

> I've created https://bugzilla.samba.org/show_bug.cgi?id=13308 for this
> and will review it now.
> Am 26.02.2018 um 14:39 schrieb Alexander Bokovoy via samba-technical:
>> On ma, 26 helmi 2018, Github bot account via samba-technical wrote:
>>> There is an updated pull request by abbra against master on the Samba Samba Github repository
>>> https://github.com/abbra/samba smb2-trust
>>> https://github.com/samba-team/samba/pull/134

>>> Submitting via github to get a test build run.
>> Travis CI build succeeded, so please review.

The Travis CI build doesn't run much tests, so this was completely

I'll push it with the attached modification:

diff --git a/python/samba/netcmd/domain.py b/python/samba/netcmd/domain.py
index fd6170e..4ce97e5 100644
--- a/python/samba/netcmd/domain.py
+++ b/python/samba/netcmd/domain.py
@@ -1733,14 +1733,14 @@ class DomainTrustCommand(Command):
         self.local_creds = local_creds
         return self.local_server

-    def _get_connection(self, connect_func, lp, creds, bindings)
+    def _get_connection(self, connect_func, lp, creds, bindings):
         """ _get_connection: try to generate a valid connection
                              using multiple bindings to allow
                              protocol fallbacks
         bnd = None
         last_exc = None
-        for binding in self.local_bindings:
+        for binding in bindings:
                 bnd = connect_func(binding, lp, creds)
                 if bnd is not None:


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20180227/7404d75b/signature.sig>

More information about the samba-technical mailing list