[PATCH] make flapping smbcontrol test more informative

Gary Lockyer gary at catalyst.net.nz
Mon Feb 26 18:11:18 UTC 2018

Ouch this was added for the pre-fork process model work and it was
intended to catch gross failures in the start up.

So it could just be limited to just the prefork test environments,
currently only addc_no_ntlm.

My preference though would be to get it working for the standard model
as well, but I'm unsure how to do this. Any thoughts, suggestions.


On 25/02/18 22:35, Ralph Böhme via samba-technical wrote:
> On Sun, Feb 25, 2018 at 09:07:06PM +1300, Douglas Bagnall via samba-technical wrote:
>> And then I thought: with multi-process fork-on-demand LDAP, we should
>> expect a race between listing the processes and pinging them. They 
>> disappear all the time.
>>         processes = self.msg_ctx.irpc_all_servers()
>>         for p in processes:
>>             for id in p.ids:
>>                 if p.name != "samba":
>>                     self.check_run("%s %d %s" % (COMMAND, id.pid, PING),
>>                                    msg="trying to ping %s" % p.name)
>> so I was wrong here:
>>>>> This is a canary, I suspect -- the test itself is sound (sort of),
>> the test is not sound.
> hehe, ouch! Good catch! :)
> -slow

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20180227/71370941/signature.sig>

More information about the samba-technical mailing list