[Fwd: Re: [PATCH] Minor cleanup of libnet_LookupName_recv] || 2nd reviewer, please

Ralph Böhme slow at samba.org
Mon Feb 26 13:33:54 UTC 2018

Hi Swen,

On Mon, Feb 26, 2018 at 02:10:28PM +0100, Swen Schillig via samba-technical wrote:
> A second review would be highly appreciated on the below.
> I added the patch file for convenience.
> Thanks in advance.

thanks for the cleanup, but I have one nitpick.

Why do you use unlikely() in an error check of a code path that is probably not
performance critical?

If others don't convince me that this is good practice: nack, sorry.


Ralph Boehme, Samba Team       https://samba.org/
Samba Developer, SerNet GmbH   https://sernet.de/en/samba/

More information about the samba-technical mailing list