[PATCH] Don't make tirpc a hard requirement

Andreas Schneider asn at samba.org
Mon Feb 26 13:10:04 UTC 2018


the attached patch only issues a warning if there is no rpc header. talloc, 
tevent and others don't need it only Samba itself.

Review much appreciated.



Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             asn at samba.org
-------------- next part --------------
>From 836531a81fd1b1d8a7c7a2ff2f50e9f21d823f1a Mon Sep 17 00:00:00 2001
From: Andreas Schneider <asn at samba.org>
Date: Mon, 26 Feb 2018 14:07:28 +0100
Subject: [PATCH] replace: Only warn if rpc/rpc.h haven't been found

This is also used by talloc, tevent, etc. Those libs don't need or use

Signed-off-by: Andreas Schneider <asn at samba.org>
 lib/replace/wscript | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/lib/replace/wscript b/lib/replace/wscript
index 2c638b77212..a2e2d118477 100644
--- a/lib/replace/wscript
+++ b/lib/replace/wscript
@@ -82,8 +82,7 @@ def configure(conf):
             conf.CHECK_HEADERS('rpc/rpc.h rpc/nettype.h', lib='tirpc', together=True)
             conf.SET_TARGET_TYPE('tirpc', 'SYSLIB')
     if not conf.CONFIG_SET('HAVE_RPC_RPC_H'):
-            Logs.error('ERROR: No rpc/rpc.h header found, tirpc or libntirpc missing?')
-            sys.exit(1)
+            Logs.warn('No rpc/rpc.h header found, tirpc or libntirpc missing?')
     conf.SET_TARGET_TYPE('nsl', 'EMPTY')
     conf.CHECK_HEADERS('rpc/rpc.h rpcsvc/yp_prot.h', lib='tirpc')

More information about the samba-technical mailing list