[PATCH] Another modified memory reference provided by value / Minor cleanup

Swen Schillig swen at vnet.ibm.com
Sat Feb 24 10:57:21 UTC 2018

Hi Jeremey
On Fri, 2018-02-23 at 15:13 -0800, Jeremy Allison via samba-technical
> This one might be OK, however you're doing a boatload
> of reformatting of code mixed in with the change.
> That makes it impossible to review cleanly (plus
> the reformatting you're doing on things like the
> argument list to push_blocking_lock_request()
> makes the code *much* harder to read, not easier).
> There's a reason we do:
> 	RETURN function(parameter1,
> 			parameter2,
> 			parameter3,
> 			..
> 			parameterN);
> It's easier to read. And not:
> 	RETURN functions(parameter1, parameter2, parameter3,
> 			.. parameterN);
> Can you separate out the single change you're doing
> here, and re-post ?

those 2 were discussed in length weeks ago with Metze and after a few
exchange of arguments it was decided to dump them.
Sorry, but thanks for your review.

Could you instead please consider the ones I sent to you recently ?
The patches from both mails were all reviewed by Christof and one
patchset in addition from Andreas,
That's the one which got pushed to autobuild as far as I remember, but
haven't heard anything from it since.

Both I sent to you directly as well, maybe you can check your inbox for
them :-)

Anyway, thanks in advance for all your efforts.

Cheers Swen.

More information about the samba-technical mailing list