[PATCH] samba-tool group list
rpenny at samba.org
Thu Feb 22 11:17:02 UTC 2018
On Wed, 21 Feb 2018 21:52:58 +0000
Rowland Penny via samba-technical <samba-technical at lists.samba.org>
> On Thu, 22 Feb 2018 10:46:40 +1300
> Douglas Bagnall <douglas.bagnall at catalyst.net.nz> wrote:
> > On 22/02/18 10:28, Rowland Penny via samba-technical wrote:
> > >> As to *why*: it isn't just about showing that the patch works
> > >> now, it is about ensuring nobody makes a change in the future
> > >> that stops it working.
> > >
> > > I can understand that Samba needs tests, but does it needs so
> > > many ?? It wasn't that long ago that autobuild seemed to be in
> > > total failure. My personal opinion (for what it is worth) is that
> > > the test setup at present is too complex, is written in too many
> > > languages and fails all too readily.
> > Fair enough. That is why I would prefer you to stick with the
> > existing language test infrastructure and language for samba-tool.
> > Having some of the group tests in the python harness and some in a
> > shell script somewhere does not simplify the situation.
> Tough, I am writing it in the language I am most at ease with and
> which I feel all the samba-tool tests should be written in, sh.
OK, here is the patch with test. It passes a local test I ran.
I also re-fixed this wiki page:
It had a regression.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 5192 bytes
Desc: not available
More information about the samba-technical