[PATCH] fix util/rfc1738.c

Douglas Bagnall douglas.bagnall at catalyst.net.nz
Tue Feb 20 22:32:29 UTC 2018

On 21/02/18 09:59, Douglas Bagnall via samba-technical wrote:
> We have a file called rfc1738.c that implements a few functions for
> handling URL-style percent-encoding. It has a few unfortunate issues
> and shows little sign of having read the eponymous RFC, which in any
> case was obsoleted by RFC 3986 in 2004.
> This set of patches introduces tests and fixes many problems,
> simplifying code along the way. Unused functions are removed, bizarre
> encodings are avoided, and error detection is introduced.
> [...]
This version has tests that output the right format for subunit. Just
this line is added:

--- a/lib/util/tests/rfc1738.c
+++ b/lib/util/tests/rfc1738.c
@@ -406,5 +406,6 @@ int main(int argc, const char **argv)

+       cmocka_set_message_output(CM_OUTPUT_SUBUNIT);
        return cmocka_run_group_tests(tests, NULL, NULL);

-------------- next part --------------
A non-text attachment was scrubbed...
Name: rfc1738v2.patch
Type: text/x-patch
Size: 38653 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20180221/43493136/rfc1738v2.bin>

More information about the samba-technical mailing list