[Patches] AD DC and lsa lookup sids/names for trusts

Stefan Metzmacher metze at samba.org
Tue Feb 20 16:12:13 UTC 2018

Hi Andreas,

> s3:cli_lsarpc: use talloc_zero_array() in dcerpc_lsa_lo...
> s3:cli_lsarpc: use talloc_zero_array() in dcerpc_lsa_lo...
> could you please split the 'if' in two lines while at it?
>   names = talloc_zero_array(mem_ctx, char *, num_sids);
>   if (name == NULL) {


> ***
> rpcclient: add lookupsids_level command
> The pointers are not initialized with NULL
> Also if-clause for-loop miss brackets { } ... CVE-2014-1266

Done, also for the existing lookupnames_level command

> s4:rpc_server/lsa: base dcesrv_lsa_LookupNames2() on 
> dcesrv_lsa_LookupNames_common()
> struct lsa_LookupNames3 r2;
> Use struct lsa_LookupNames3 r2 = {0}; and remove the ZERO_STRUCT(r2) then.

Skipped, as this is just on temporary commit and there's no
ZERO_STRUCT() in the final result.

I also think it's strange to use
{0,} for a structure that has only anonymous sub structures
instead of a first element that could be initialized with 0.

Pushed to autobuild...


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20180220/b4265181/signature.sig>

More information about the samba-technical mailing list