[PATCH] Don't load LDB_MODULESDIR as a module file

[Uri Simchoni]

On 02/14/2018 05:16 PM, Andreas Schneider via samba-technical wrote:
> On Wednesday, 14 February 2018 03:23:59 CET Timur I. Bakeyev via samba-
> technical wrote:
>> Hi!
>>
>> While running test suite for ldb I got annoyed by hume amount of warnings
>> about missing
>> module /usr/local/lib/shared-modules/ldb , which is in fact directory,
>> where installed modules should reside. But as ldb wasn't installed yet -
>> this directory didn't exist.
>>
>> Short investigation showed that inside the ldb_set_modules_dir() function
>> we, apparently wrongfully call ldb_modules_load_path(), which is meant to
>> load particular modules instead of ldb_modules_load_dir(), which processes
>> directory with those modules.
>>
>> Here is a small patch that fixes the situation.
> 
> RB+
>  

RB+ and pushing.
(also pushing the 'bashism' patches that didn't break the build, with
their respective RB's)

Thanks,
Uri.

>> Starting index test
>>
>>> ldb: unable to stat module /usr/local/lib/shared-modules/ldb : No such
>>> file or directory
>>> Finished index test
>>> Testing one level search
>>> ldb: unable to stat module /usr/local/lib/shared-modules/ldb : No such
>>> file or directory
>>> Testing binary file attribute value
>>> ldb: unable to stat module /usr/local/lib/shared-modules/ldb : No such
>>> file or directory
>>> Modified 1 records successfully
>>> ldb: unable to stat module /usr/local/lib/shared-modules/ldb : No such
>>> file or directory
>>> *TODO* Testing UTF8 upper lower case searches !!
>>> Testing compare
>>> ldb: unable to stat module /usr/local/lib/shared-modules/ldb : No such
>>> file or directory
>>> ldb: unable to stat module /usr/local/lib/shared-modules/ldb : No such
>>> file or directory
>>> allocating request failed: Unable to parse search expression
>>> ldb: unable to stat module /usr/local/lib/shared-modules/ldb : No such
>>> file or directory
>>> ldb: unable to stat module /usr/local/lib/shared-modules/ldb : No such
>>> file or directory
>>> allocating request failed: Unable to parse search expression
>>> ldb: unable to stat module /usr/local/lib/shared-modules/ldb : No such
>>> file or directory
>>> OK: 0 (uid=uham)
> 
>