PATCH: netbios c-python lib (bug) + python tests for module + python3 port

[Noel Power]

On 15/02/18 23:27, Andrew Bartlett wrote:
> On Thu, 2018-02-15 at 21:22 +0000, Noel Power via samba-technical
> wrote:
>> This patch set is for
[...]
>> This fails autobuild with:
>>
>> ../libcli/nbt/pynbt.c:390:2: error: missing braces around initializer
>> [-Werror=missing-braces]
>>   PyObject_HEAD_INIT(NULL) 0,
>>   ^
>> ../libcli/nbt/pynbt.c:390:2: error: (near initialization for
>> nbt_node_Type.ob_base.ob_base) [-Werror=missing-braces]
yep I saw this error and just assumed that it was pre-existing, it
appears though it is as a result of enabling python3 though.
fixed now.
> cc1: all warnings being treated as errors
> Waf: Leaving directory `/home/ubuntu/autobuild/b19883/samba/bin'
> Build failed:  -> task failed (err #1): 
>         {task: cc pynbt.c -> pynbt_12.o}
> make: *** [all] Error 1
>
> Can you please push to a github branch and get that to pass travis CI?
done (awaiting ci results) patch attached also
Noel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: netbios-patchesv2.patch
Type: text/x-patch
Size: 12804 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20180216/781e5953/netbios-patchesv2.bin>