[PATCH] Use arc4random() to permutate talloc_magic number

Andrew Bartlett abartlet at samba.org
Fri Feb 16 02:50:23 UTC 2018


On Fri, 2018-02-16 at 03:32 +0100, Timur I. Bakeyev wrote:
> 
> Is your main concern regarding this patch that it makes arc4random() preferable choice
> over getauxval()? That can be fixed with some code re-arrangement and macro magic.

Yes.

I'm also keen that we somehow ensure that arc4random() is detected only
in libc (probably OK right now) but add some comments defending the use
in the wscript so that if someone else adds a test for arc4random from
libbsd we find this discussion.

Andrew Bartlett

-- 
Andrew Bartlett
https://samba.org/~abartlet/
Authentication Developer, Samba Team         https://samba.org
Samba Development and Support, Catalyst IT   
https://catalyst.net.nz/services/samba







More information about the samba-technical mailing list