PATCHv2: adjust 'net ads add keytab' for windows SPN(s) & add new 'net ads setspn' subcommand

Andrew Bartlett abartlet at
Thu Feb 15 23:49:57 UTC 2018

On Thu, 2018-02-15 at 10:42 +0000, Noel Power via samba-technical
> Hi All
> I've updated the patch set hopefully to address the details brought up

Thanks for including tests, however it doesn't look like all the
changes are tested as the last test is in patch 10/16, misisng the
changes to the default behaviour of net ads keytab add etc.

Please add some more tests to ensure all the changes are covered.  

A good way to know the test is covering the changes is to have it in a
file within selftest/knownfail.d/ (works best for python, not sure how
well that goes for sh) and then remove the knownfail when the change is


Andrew Bartlett
Andrew Bartlett
Authentication Developer, Samba Team
Samba Development and Support, Catalyst IT

More information about the samba-technical mailing list