PATCH: netbios c-python lib (bug) + python tests for module + python3 port

[Andrew Bartlett]

On Thu, 2018-02-15 at 21:22 +0000, Noel Power via samba-technical
wrote:
> This patch set is for
> 
> a) bug in netbios python c-module
> 
> b) very very basic python tests for the module (found the bug above at
> least)
> 
> c) port of netbios python c-module to python3
> 
> d) enabled of the test for python3 too
> 
> 
> please have a look

This fails autobuild with:

../libcli/nbt/pynbt.c:390:2: error: missing braces around initializer
[-Werror=missing-braces]
  PyObject_HEAD_INIT(NULL) 0,
  ^
../libcli/nbt/pynbt.c:390:2: error: (near initialization for
nbt_node_Type.ob_base.ob_base) [-Werror=missing-braces]
cc1: all warnings being treated as errors
Waf: Leaving directory `/home/ubuntu/autobuild/b19883/samba/bin'
Build failed:  -> task failed (err #1): 
        {task: cc pynbt.c -> pynbt_12.o}
make: *** [all] Error 1

Can you please push to a github branch and get that to pass travis CI?

(A gitlab option will arrive sometime soon).

Thanks,

Andrew Bartlett

-- 
Andrew Bartlett
https://samba.org/~abartlet/
Authentication Developer, Samba Team         https://samba.org
Samba Development and Support, Catalyst IT   
https://catalyst.net.nz/services/samba