[PATCH] Avoid replication corruption on the RODC

[Andrew Bartlett]

On Wed, 2018-02-14 at 16:25 +1300, Garming Sam via samba-technical
wrote:
> Filed a bug and added the tags on the patches.
> 
> https://bugzilla.samba.org/show_bug.cgi?id=13269
> 
> 
> On 14/02/18 13:48, Garming Sam wrote:
> > Hi,
> > 
> > Attached are some patches to fix this particular issue in the RODC as
> > well as the tests. What has happened is that an error code has not been
> > set in the failure case on an RODC when a conflict record must be
> > created (which the RODC cannot do alone). This meant that the RODC
> > silently skips the object or update, but still updates the highwatermark
> > and up-to-dateness vector as if it had applied the update.
> > 
> > Please review and push.
> > 
> > 
> > Cheers,
> > 
> > Garming

Thanks Garming.  This looks great.  The trick with using single-object
replication to get objects from a single DC to conflict with itself it
really neat!

Reviewed-by: Andrew Bartlett <abartlet at samba.org>

Please push to autobuild!

Andrew Bartlett

-- 
Andrew Bartlett
https://samba.org/~abartlet/
Authentication Developer, Samba Team         https://samba.org
Samba Development and Support, Catalyst IT   
https://catalyst.net.nz/services/samba