Some code cleanups

Andrew Bartlett abartlet at
Wed Feb 14 23:17:05 UTC 2018

On Tue, 2018-02-13 at 12:31 +0100, Andreas Schneider via samba-
technical wrote:
> Hi,
> some patches for cleaning up code while looking into it.
> Please review and push if OK.

Sadly this fails make test:

 [PATCH 1/3] util: Add sanity check for count in ms_fnmatch_protocol()

We need to initialize `ret` in case the 'if' condition is false.

It fails with:

[1(0)/1 at 0s] samba4.raw.unlink(ad_dc_ntvfs)
smbtorture 4.9.0pre1-DEVELOPERBUILD
Using seed 1518649817
Trying non-existent file
Trying a hidden file
Trying a directory
Trying a bad path
Trying wildcards
(../source4/torture/raw/unlink.c:154) Incorrect status
UNEXPECTED(error): samba4.raw.unlink.unlink(ad_dc_ntvfs)
REASON: Exception: Exception: Unknown error/failure. Missing
torture_fail() or torture_assert_*() call?


Andrew Bartlett

Andrew Bartlett
Authentication Developer, Samba Team
Samba Development and Support, Catalyst IT

More information about the samba-technical mailing list