[PATCHES] bulk conversion of python except clauses to new form

Andrew Bartlett abartlet at samba.org
Wed Feb 14 04:00:11 UTC 2018

On Wed, 2018-02-14 at 11:30 +1300, Douglas Bagnall via samba-technical
> Last week Jim Brown wrote in response to one of my patches:
> > While you are here would it make sense to change 'except Exception,
> > e:' to use "as" instead of ","?
> which I ignored because, well, if you follow every stylistic nit that
> shows up in diff context in samba-tool code, you'll never finish
> anything.
> But it made me think about how easy it would be to do this
> automatically, using e.g.
> perl -p -i -e 's/except\s+([\w.]+)\s*,\s*(\w+)\s*:/except $1 as $2:/' <FILES>
> and this morning I did that.
> I have split it into a few patches, roughly by directory.

Looks good.  Reviewed-by: Andrew Bartlett <abartlet at samba.org>

In autobuild.


> Douglas
Andrew Bartlett
Authentication Developer, Samba Team         https://samba.org
Samba Development and Support, Catalyst IT   

More information about the samba-technical mailing list