[PATCH] Don't load LDB_MODULESDIR as a module file

[Timur I. Bakeyev]

Hi!

While running test suite for ldb I got annoyed by hume amount of warnings
about missing
module /usr/local/lib/shared-modules/ldb , which is in fact directory,
where installed modules should reside. But as ldb wasn't installed yet -
this directory didn't exist.

Short investigation showed that inside the ldb_set_modules_dir() function
we, apparently wrongfully call ldb_modules_load_path(), which is meant to
load particular modules instead of ldb_modules_load_dir(), which processes
directory with those modules.

Here is a small patch that fixes the situation.

Starting index test
> ldb: unable to stat module /usr/local/lib/shared-modules/ldb : No such
> file or directory
> Finished index test
> Testing one level search
> ldb: unable to stat module /usr/local/lib/shared-modules/ldb : No such
> file or directory
> Testing binary file attribute value
> ldb: unable to stat module /usr/local/lib/shared-modules/ldb : No such
> file or directory
> Modified 1 records successfully
> ldb: unable to stat module /usr/local/lib/shared-modules/ldb : No such
> file or directory
> *TODO* Testing UTF8 upper lower case searches !!
> Testing compare
> ldb: unable to stat module /usr/local/lib/shared-modules/ldb : No such
> file or directory
> ldb: unable to stat module /usr/local/lib/shared-modules/ldb : No such
> file or directory
> allocating request failed: Unable to parse search expression
> ldb: unable to stat module /usr/local/lib/shared-modules/ldb : No such
> file or directory
> ldb: unable to stat module /usr/local/lib/shared-modules/ldb : No such
> file or directory
> allocating request failed: Unable to parse search expression
> ldb: unable to stat module /usr/local/lib/shared-modules/ldb : No such
> file or directory
> OK: 0 (uid=uham)
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Don-t-load-LDB_MODULESDIR-as-a-module-file.patch
Type: application/octet-stream
Size: 1068 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20180214/0fe9fef5/0001-Don-t-load-LDB_MODULESDIR-as-a-module-file-0001.obj>