[PATCH] Remove "file_id" from share_mode_entry

Volker Lendecke Volker.Lendecke at SerNet.DE
Tue Feb 13 07:52:24 UTC 2018

On Mon, Feb 12, 2018 at 02:47:18PM -0800, Jeremy Allison wrote:
> > share_mode_entries are always part of a locking.tdb entry. Those
> > entries are per inode, and a "struct file_id" describes that. The
> > "file_id" (24 bytes) is redunant in the share mode entry, we can
> > always access that via the share_mode_data.
> > 
> > Review appreciated!
> That is a really nice cleanup, and a great catch that
> this value is redundant in the shared databases (the
> less in there the better). Was this one my fault ?

Didn't look. Thanks for pushing!


Besuchen Sie die verinice.XP 2018 in Berlin,
Anwenderkonferenz für Informationssicherheit
vom 21.-23.03.2018 im Sofitel Kurfürstendamm
Info & Anmeldung hier: http://veriniceXP.org

SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de

More information about the samba-technical mailing list